fix: run error hook when provider returns error code#951
Merged
beeme1mr merged 3 commits intoMay 30, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #951 +/- ##
============================================
+ Coverage 94.98% 95.26% +0.28%
- Complexity 383 392 +9
============================================
Files 36 37 +1
Lines 877 887 +10
Branches 53 54 +1
============================================
+ Hits 833 845 +12
+ Misses 24 23 -1
+ Partials 20 19 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Kavindu-Dodan
force-pushed
the
bugfix/928_error_hooks_only_run_if_provider_throws
branch
from
0f197a0 to
06b7ad2
Compare
Contributor
|
I have this suggestion, otherwise looks good :) |
Kavindu-Dodan
approved these changes
May 24, 2024
Kavindu-Dodan
left a comment
Kavindu-Dodan
left a comment
Contributor
There was a problem hiding this comment.
@jarebudev Nice work 🙌
toddbaert
reviewed
May 27, 2024
Kavindu-Dodan
force-pushed
the
bugfix/928_error_hooks_only_run_if_provider_throws
branch
from
3129001 to
5769409
Compare
Signed-off-by: jarebudev <23311805+jarebudev@users.noreply.github.com>
Signed-off-by: jarebudev <23311805+jarebudev@users.noreply.github.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
bugfix/928_error_hooks_only_run_if_provider_throws
branch
from
5769409 to
380b177
Compare
|
toddbaert
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #928
Notes
saw this bug and seemed like a straightforward fix, wasn't sure if anyone has already picked it up so feel free to reject if it's already been taken on